Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bitcoin): <- adds fee hardcap #8

Merged
merged 2 commits into from
Dec 19, 2023
Merged

feat(bitcoin): <- adds fee hardcap #8

merged 2 commits into from
Dec 19, 2023

Conversation

gskapka
Copy link
Contributor

@gskapka gskapka commented Dec 18, 2023 •
edited
Loading

...per title.

Anything resulting in a transaction with a fee over the hard-coded cap will return an error.

Note: The linting CI will error due to some things that have been fixed in the sentinel branch, and so have been left unfixed in this PR to keep the rebase simpler.

gitmp01
gitmp01 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@gitmp01 gitmp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

common/bitcoin/src/btc_constants.rs Show resolved Hide resolved
common/bitcoin/src/btc_transaction.rs Show resolved Hide resolved
@gskapka gskapka self-assigned this Dec 19, 2023
@gskapka gskapka merged commit 9eb2e6c into master Dec 19, 2023
3 of 5 checks passed
@gskapka gskapka deleted the btc-fee-hardcap branch December 19, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitmp01 gitmp01 gitmp01 approved these changes

Assignees

@gskapka gskapka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gskapka @gitmp01