Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slides saving in different folder issue and add professor name to lecture folder name #29

Merged
merged 8 commits into from
Dec 31, 2024
Merged

Fix slides saving in different folder issue and add professor name to lecture folder name #29

merged 8 commits into from
Dec 31, 2024

Conversation

HemanthK-12
Copy link
Contributor

@HemanthK-12 HemanthK-12 commented Dec 26, 2024 •
edited
Loading

  • Fixes slides saving to same folder issue by replacing the hardcoded ./slides statement with config.downloadlocation, which stores the path till the subject folder location ( after the CreateDirInsideDownloads function call).
  • Added Professor Name to the folder name by adding the value courses[choice-1].ProfessorName during name creation.
  • Added comments at places where there are calls to functions in different files, to improve code navigation and readability,
  • Fixes Issue Slides always saving in the same folder #28 .

@pnicto pnicto linked an issue Dec 29, 2024 that may be closed by this pull request
Slides always saving in the same folder #28
Closed
pnicto
pnicto requested changes Dec 29, 2024
View reviewed changes
Copy link
Owner

@pnicto pnicto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you undo all the comments? I don't think you wanted to push the comments(those that indicate the filename eg., // in config.go etc.,)

impartus.go Outdated Show resolved Hide resolved
impartus.go Outdated Show resolved Hide resolved
pnicto
pnicto requested changes Dec 31, 2024
View reviewed changes
Copy link
Owner

@pnicto pnicto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

impartus.go Outdated Show resolved Hide resolved
@pnicto pnicto self-requested a review December 31, 2024 04:47
pnicto
pnicto approved these changes Dec 31, 2024
View reviewed changes
Copy link
Owner

@pnicto pnicto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! And thanks for your contribution 😄

@pnicto pnicto merged commit edeeb64 into pnicto:main Dec 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnicto pnicto pnicto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slides always saving in the same folder
2 participants
@HemanthK-12 @pnicto