Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc fix infinite recursion on mutually recursive Deref impl #2

Conversation

trinity-1686a
Copy link

fix for rust-lang#85095 requires part of what is already on this branch, plus some additional code (see issue comments), and is closely related to the goal of this branch, so I think it's best to include the changes together. Feel free to close if you don't think so, in that case I'll open a pr upstream once rust-lang#84867 get merged

@trinity-1686a trinity-1686a changed the title Rustdoc revert deref recur Rustdoc fix infinitre recursion on mutually recursive Deref impl May 9, 2021
@trinity-1686a trinity-1686a changed the title Rustdoc fix infinitre recursion on mutually recursive Deref impl Rustdoc fix infinite recursion on mutually recursive Deref impl May 9, 2021
@pnkfelix pnkfelix force-pushed the rustdoc-revert-deref-recur branch from 86e3f76 to b894f75 Compare June 10, 2021 09:53
pnkfelix pushed a commit that referenced this pull request Sep 9, 2021
Otherwise, we can get into a situation where you have
a subtype obligation `#1 <: #2` pending, #1 is constrained
by `check_casts`, but #2` is unaffected.

Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
pnkfelix pushed a commit that referenced this pull request Jun 7, 2024
Co-authored-by: Jaisurya Nanduri <91620234+jaisnan@users.noreply.github.com>
pnkfelix pushed a commit that referenced this pull request Jun 10, 2024
Co-authored-by: Jaisurya Nanduri <91620234+jaisnan@users.noreply.github.com>
celinval added a commit that referenced this pull request Jan 10, 2025
…ract lang items

includes post-developed commit: do not suggest internal-only keywords as corrections to parse failures.

includes post-developed commit: removed tabs that creeped in into rustfmt tool source code.

includes post-developed commit, placating rustfmt self dogfooding.

includes post-developed commit: add backquotes to prevent markdown checking from trying to treat an attr as a markdown hyperlink/

includes post-developed commit: fix lowering to keep contracts from being erroneously inherited by nested bodies (like closures).

Rebase Conflicts:
 - compiler/rustc_parse/src/parser/diagnostics.rs
 - compiler/rustc_parse/src/parser/item.rs
 - compiler/rustc_span/src/hygiene.rs

# This is the commit message #2:

Remove contracts keywords from diagnostic messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants