Rds/kjw/function get swh uses associated with each building segment #1712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarenWGard
requested review from
JacksonJ-KC,
JasonGlazer,
claperle,
supriyagoel and
weilixu
claperle
approved these changes
Apr 24, 2025
| - create the list for this building segment: `swh_uses_dict[bldg_seg.id] = []` | ||
| - look at each swh use in the building segment: `for swh_use in bldg_seg.service_water_heating_uses:` | ||
| - append the swh use id to the bldg_seg list: `swh_uses[bldg_seg.id].append(swh_use.id)` | ||
| - look at each space in the building segment: `for space in build_seg...spaces:` |
Collaborator
There was a problem hiding this comment.
@KarenWGard Here are my understanding of this change.
- The description in line 9 says
a list service_water_heating_uses objects, but what this implementation does is to have a list ofswh_useids, which is different from what the description says. - If we make this change, the 11-11, 11-12 rules have an error. How would you handle this?
weilixu
deleted the
RDS/KJW/function_get_SWH_uses_associated_with_each_building_segment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated to reflect schema changes for open229/ruleset-model-description-schema#349