Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update date-range-rag-days-left.json #902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CastilloIT
Copy link

Hi,
For Q4 2024 in sharepoint acts good, but not ideally due to parenthesis not closing properly, I added the closing brackets and works without issues now.

Q A
Bug fix? no - yes?
New sample? no - yes?
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

Guidance

You can delete this section when you are submitting the pull request.

  • Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
  • Please target your PR to 'master' branch.

Thanks for your contribution! Sharing is caring.

Hi,
For Q4 2024 in sharepoint acts good, but not ideally due to parenthesis not closing properly, I added the closing brackets and works without issues now.
@tecchan1107 tecchan1107 self-assigned this Dec 28, 2024
@tecchan1107
Copy link
Collaborator

Thank you for the update, @CastilloIT !

I’d like to confirm one point:
Is this pull request intended to fix the expression for the border-color on line 7 and the class on line 20 in date-range-rag-days-left.json?

The reason I ask is that the pull request also includes changes such as text color adjustments, among other things.

If the text color changes, etc., were not intentional, I’m considering excluding those sections from the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants