Skip to content
This repository was archived by the owner on Jan 19, 2021. It is now read-only.

Fixing issue matching Delve Blog page with ConvertTo-PnPClientSidePage #2411

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Fixing issue matching Delve Blog page with ConvertTo-PnPClientSidePage #2411

merged 1 commit into from
Dec 16, 2019

Conversation

KoenZomers
Copy link
Collaborator

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

N/A

What is in this Pull Request ?

If using:

ConvertTo-PnPClientSidePage -Identity "Alex's Blog Post" -Overwrite -TargetWebUrl "https://contoso.sharepoint.com/sites/AlexBlog" -KeepPageCreationModificationInformation -PostAsNews -SetAuthorInPageHeader -DelveKeepSubTitle -Verbose -DelveBlogPage

It would not match any page and throw a nullreferenceexception. Fixed the code so it shows a message that the page could not be found instead. Also fixed that if the page contains specific characters such as & like in "Alex's Blog Post #1" that it will HTML Encode the name first before feeding it it to the CAML query, otherwise it would never find and return the page.

@KoenZomers KoenZomers self-assigned this Dec 14, 2019
@KoenZomers KoenZomers added the status:checked and ready for merge ✔ PR has been checked and is ready for merge label Dec 14, 2019
@KoenZomers KoenZomers changed the title Fixing issue matching Delve Blog page with Fixing issue matching Delve Blog page with ConvertTo-PnPClientSidePage Dec 14, 2019
@erwinvanhunen erwinvanhunen merged commit ec17900 into pnp:dev Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:checked and ready for merge ✔ PR has been checked and is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants