This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 643
Allow removal of document set items & added name on document set items export #2624
Open
KoenZomers
wants to merge
10
commits into
pnp:dev
Choose a base branch
from
KoenZomers:AllowRemovalOfDocSetItems
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AllowedContentTypes, SharedFields and WelcomePageFields to indicate an item should be removed. Also added an optional Name string attribute to provide an identifier for the field reference.
…need to do the welcome page fields.
…wRemovalOfDocSetItems
…tTemplate which gets filled on creating a template so it becomes more easy to identify which fields it are, added Remove boolean attribute on SharedFields, WelcomePageFields and AllowedContentTypes in DocumentSetTemplate to allow for any of those to explicitly be removed again from the document set. This wasn't possible before, you could only add.
jansenbe
added
Needs: Schema Changes 🛠
status:tracked
Triaged and are being investigated further
type:enhancement
New feature or enhancement of existing capability
labels
Apr 16, 2020
Hi @KoenZomers, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Needs: Schema Changes 🛠
status:tracked
Triaged and are being investigated further
type:enhancement
New feature or enhancement of existing capability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Added Name column to SharedFields and WelcomePageFields in DocumentSetTemplate which gets filled on creating a template so it becomes more easy to identify which fields it are, added Remove boolean attribute on SharedFields, WelcomePageFields and AllowedContentTypes in DocumentSetTemplate to allow for any of those to explicitly be removed again from the document set. This wasn't possible before, you could only add.
Note that the required schema changes for this are included in the latest schema so I could fully test this through.
Schema changes are requested here:
pnp/PnP-Provisioning-Schema#502