Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Allow removal of document set items & added name on document set items export #2624

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Allow removal of document set items & added name on document set items export #2624

wants to merge 10 commits into from

Conversation

KoenZomers
Copy link
Contributor

@KoenZomers KoenZomers commented Apr 16, 2020

Q A
Bug fix? no
New feature? yes
New sample? no
Related issues? N/A

What's in this Pull Request?

Added Name column to SharedFields and WelcomePageFields in DocumentSetTemplate which gets filled on creating a template so it becomes more easy to identify which fields it are, added Remove boolean attribute on SharedFields, WelcomePageFields and AllowedContentTypes in DocumentSetTemplate to allow for any of those to explicitly be removed again from the document set. This wasn't possible before, you could only add.

Note that the required schema changes for this are included in the latest schema so I could fully test this through.

Schema changes are requested here:
pnp/PnP-Provisioning-Schema#502

… AllowedContentTypes, SharedFields and WelcomePageFields to indicate an item should be removed. Also added an optional Name string attribute to provide an identifier for the field reference.
…tTemplate which gets filled on creating a template so it becomes more easy to identify which fields it are, added Remove boolean attribute on SharedFields, WelcomePageFields and AllowedContentTypes in DocumentSetTemplate to allow for any of those to explicitly be removed again from the document set. This wasn't possible before, you could only add.
@PaoloPia
Copy link
Contributor

Hi @KoenZomers,
Thanks for your contribution. Unfortunately, I cannot merge it as is. I need first to apply the changes to a new schema release that I'm going to start working on. I'll keep this PR on hold and, when the new schema will be ready, I'll come back to this one. In the meantime, I'll create an issue in the schema repo to not loose this valuable input. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: Schema Changes 🛠 status:tracked Triaged and are being investigated further type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants