Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to delete sections, columns and controls #13

Closed
2 tasks
raymondlittle100 opened this issue Feb 22, 2018 · 4 comments · Fixed by #60
Closed
2 tasks

Ability to delete sections, columns and controls #13

raymondlittle100 opened this issue Feb 22, 2018 · 4 comments · Fixed by #60

Comments

@raymondlittle100
Copy link

Category

  • [ x] Enhancement
  • Bug
  • [x ] Question
  • Documentation gap/issue

Version

Please specify what version of the library you are using: [ 1.0.2 ]

Expected / Desired Behavior / Question

Looking over the client side pages functionality there is the ability to add new sections, columns and controls but there is nothing to delete them. This would be really useful

@patrick-rodgers
Copy link
Member

You can manipulate the arrays using the standard array methods such as slice.

Obviously we can make things easier - what would that look like? Would each control/column etc. have a delete or remove? What should happen to controls in a section if I delete it - delete them or keep them somehow?

@raymondlittle100
Copy link
Author

Ah never thought of that :). So if i remove the items from the array when the page save happens will that detect the sections/columns have gone and delete them?

In terms of controls its difficult but you could have a method with some overloads. The default could be there are deleted and you pass a flag to say false and it moves them to the first section. Alternatively the overload could be to pass a section and column where any controls would go instead of being deleted. What you think?

@patrick-rodgers
Copy link
Member

Added a remove method to section, column, and part that will take them out of the collection.

patrick-rodgers pushed a commit that referenced this issue Dec 4, 2020
@github-actions
Copy link

This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked.

@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants