Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating methods for valid syntax #1459

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

bcameron1231
Copy link
Collaborator

The syntax for the examples are incorrect. Replacing "Add" to "Push" for the array object, and adding () for the method calls.

Category

  • Documentation update

Related Issues

None

What's in this Pull Request?

Updating the documentation as it appears to have incorrect syntax for accessing the currentUser, siteUsers as well as the example method for adding to an array.

The syntax for the examples are incorrect. Replacing "Add" to "Push" for the array object, and adding () for the method calls.
@juliemturner
Copy link
Collaborator

Thanks for the fix!

@juliemturner juliemturner added this to the 2.0.13 milestone Dec 2, 2020
The previous commit included a code change for adding a site user incorrectly. I changed this back to the correct usage, by remove () on siteUsers and replacing 'push' with 'add'
@patrick-rodgers
Copy link
Member

Thanks @bcameron1231!

@patrick-rodgers patrick-rodgers merged commit aecc956 into pnp:version-2 Dec 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants