Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with addChunked method #1463

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Fixed issue with addChunked method #1463

merged 4 commits into from
Dec 14, 2020

Conversation

tavikukko
Copy link
Contributor

Category

  • Bug fix?
  • New feature?
  • New sample?
  • Documentation update?

Related Issues

fixes #1462

What's in this Pull Request?

Fixes issue where Web object is created manually and file is added using addChunked method. The file was created but no content was added because the file was always searched from context, not from the crafted Web. This PR fixes that issue.

@juliemturner juliemturner added this to the 2.0.13 milestone Dec 6, 2020
@juliemturner
Copy link
Collaborator

Thanks for the update!

Copy link
Member

@patrick-rodgers patrick-rodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tavikukko - appreciate this but can you help me understand the bug we are fixing? I saw the related issue but what was the problem? Looking at your change I am guessing they are trying to upload to a different site?

@patrick-rodgers
Copy link
Member

Thanks!

@patrick-rodgers patrick-rodgers merged commit 7c01ce8 into pnp:version-2 Dec 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.files.addChunked(.. error Error making HttpClient request in queryable [404]
3 participants