Merge pull request #2138 from fowl2/fixGetSiteSearchQueryResults

GetSiteSearchQueryResults: fix 'Value cannot be null' exception

CHANGELOG.md

@@ -16,9 +16,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 ### Fixed
 - Fixed issue where passing in `-Connection` to `Disconnect-PnPOnline` would throw an exception [#2093](https://github.com/pnp/powershell/pull/2093)
+- Fixed `Get-PnPSiteSearchQueryResults` throwing `Value cannot be null` exception [#2138](https://github.com/pnp/powershell/pull/2138)
 
 ### Contributors
 
+- James May [fowl2]
 - Jimmy Hang [JimmyHang]
 - Marcus Blennegård [mblennegard]
 - Arleta Wanat [PowerShellScripts]

src/Commands/Search/GetSiteSearchQueryResults.cs

@@ -1,5 +1,4 @@
 using System.Management.Automation;
-
 using System.Collections.Generic;
 
 namespace PnP.PowerShell.Commands.Search
@@ -22,16 +21,18 @@ public class GetSiteSearchQueryResults : PnPWebCmdlet
 
         protected override void ExecuteCmdlet()
         {
-            var queryCmdLet = new SubmitSearchQuery();
-
-            queryCmdLet.StartRow = StartRow;
-            queryCmdLet.MaxResults = MaxResults;
-            queryCmdLet.All = All;
+            var queryCmdLet = new SubmitSearchQuery
+            {
+                Connection = Connection,
+                StartRow = StartRow,
+                MaxResults = MaxResults,
+                All = All
+            };
 
             var query = "contentclass:STS_Site";
             if (!string.IsNullOrEmpty(Query))
             {
-                query = query + " AND " + Query;
+                query = $"{query} AND {Query}";
             }
             queryCmdLet.Query = query;
 
@@ -61,4 +62,4 @@ protected override void ExecuteCmdlet()
             WriteObject(dynamicList, true);
         }
     }
-}
+}

src/Commands/Search/SubmitSearchQuery.cs

@@ -3,7 +3,6 @@
 using System.Management.Automation;
 using Microsoft.SharePoint.Client;
 using Microsoft.SharePoint.Client.Search.Query;
-
 using System.Collections.Generic;
 using System.Linq;
 
@@ -303,5 +302,4 @@ private KeywordQuery CreateKeywordQuery(string clientFunction)
             return keywordQuery;
         }
     }
-}
-
+}