Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/exclude deprecated terms #4053

Merged
merged 15 commits into from
Oct 11, 2024

Conversation

sankarkumar23
Copy link
Contributor

@sankarkumar23 sankarkumar23 commented Jun 28, 2024

Before creating a pull request, make sure that you have read the contribution file located at

https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes #X, partially fixes #Y, mentioned in #Z, etc.

What is in this Pull Request ?

Added additional parameter to exclude deprecated terms

@markgort86
Copy link
Contributor

I think it's also a good idea to add some additional details about for this PR. See: https://pnp.github.io/powershell/articles/gettingstartedcontributing.html

@KoenZomers KoenZomers force-pushed the feature/exclude-deprecated-terms branch from bb25cc4 to 4e1a89d Compare June 30, 2024 21:10
@KoenZomers
Copy link
Collaborator

Thanks @sankarkumar23 for your contribution. I checked your PR. The way its currently written, it will only work if providing a -TermsetId. I was wondering if there was a specific reason why you didn't add the -ExcludeDeprecated parameter to the TermSet parametergroup. Now it looks like it will also work with it, but it doesn't. I have updated your PR so it's only set to that paramset.

If I missed some thoughts here why this would not be okay, let me know.

@sankarkumar23
Copy link
Contributor Author

sankarkumar23 commented Jul 4, 2024

Agree with your comments. I prepared this code a year ago when I had the same need. I was new to GitHub and didn't understand how to push a PR until markgrot86 tapped me a few weeks ago. Now, I've moved away from the SharePoint platform and can't recollect what all I missed. You can take the code if you find it useful create a new branch, make additional changes and push it, as I no longer have the environment to test it. This experience really helped me learn how to contribute to open source code.
You can delete my PR if needed.

@KoenZomers
Copy link
Collaborator

Thanks for elaborating @sankarkumar23 . I think we're good to go for a merge on this one then. I'll do a final review and test in the next days and if all works well, I'll merge it.

@KoenZomers
Copy link
Collaborator

Thanks @sankarkumar23 for your contribution!

@KoenZomers KoenZomers merged commit b803fe2 into pnp:dev Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants