Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature extension ListView > dragDropFiles V1 #711

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

aaclage
Copy link
Contributor

@aaclage aaclage commented Oct 29, 2020

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? mentioned in #682

What's in this Pull Request?

Feature added in V2 #682 and this version is to include in V1 for on premises environments (SP2019)
This is a new feature extension of ListView control with 2 new properties.
Properties:
dragDropFiles - Specify the drag and drop files area option. Default false.
onDrop - Event handler returns files from drag and drop.

Test Case:
When using ControlsTest.tsx, should retrieve in console the file names.
image

@aaclage
Copy link
Contributor Author

aaclage commented Nov 3, 2020

Hi @AJIXuMuK ,

I don't know if is allow to include new features in v1. if is not possible i can cancel this PR.
Thank you.

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Nov 3, 2020

Hi @aaclage,
Thanks for the PR.

We allow PRs to the v1 as well. The thing is - we're processing them on a low priority basis and don't have some specific plans on next releases.

@aaclage
Copy link
Contributor Author

aaclage commented Nov 4, 2020

@AJIXuMuK

Thank you for your feedback,
Make sense. i will keep here then.

@AJIXuMuK AJIXuMuK merged commit 3cdd379 into pnp:v1-dev Nov 6, 2020
@AJIXuMuK AJIXuMuK added this to the 1.21.1 milestone Nov 6, 2020
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Nov 6, 2020

This has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants