Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning Is Incorrect #5280

Closed
2 of 9 tasks
BenedictCard opened this issue Oct 3, 2024 · 1 comment
Closed
2 of 9 tasks

Versioning Is Incorrect #5280

BenedictCard opened this issue Oct 3, 2024 · 1 comment
Labels
type:bug-suspected Suspected bug (not working as designed/expected). See type:bug-confirmed for confirmed bugs

Comments

@BenedictCard
Copy link

Disclaimer

Yes

Sample

react-add-js-css-ref

Contributor(s)

me

What happened?

In the original package-json the version is set to only 3 chars, but I'm not sure if it's an isolated issue, my tenant requires 4 numbers as per:
{
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/package-solution.schema.json",
"solution": {
"name": "react-add-js-css-ref-client-side-solution",
"id": "d9c30e1a-bf06-46fa-807d-ce5182d9c91c",
"version": "1.0.0.0", // Changed to include a fourth segment
"includeClientSideAssets": true,
"isDomainIsolated": false,
"developer": {
"name": "Your Name",
"privacyUrl": "https://yourprivacyurl.com",
"termsOfUseUrl": "https://yourtermsofuse.com",
"websiteUrl": "https://yourwebsite.com",
"mpnId": "Undefined-1.14.0"
},
"metadata": {
"shortDescription": {
"default": "react-add-js-css-ref description"
},
"longDescription": {
"default": "react-add-js-css-ref description"
},
"screenshotPaths": [],
"videoUrl": "",
"categories": []
},
"features": [
{
"title": "Application Extension - Deployment of custom action.",
"description": "Deploys a custom action with ClientSideComponentId association",
"id": "201c7969-a60d-492a-83d2-db3088515c51",
"version": "1.0.0.0",
"assets": {
"elementManifests": [
"elements.xml",
"clientsideinstance.xml"
]
}
}
]
},
"paths": {
"zippedPackage": "solution/react-add-js-css-ref.sppkg"
}
}

Steps to reproduce

1.deploy to appcatalog
2.view the error of version
3.

Expected behavior

Success

Target SharePoint environment

SharePoint Online

Developer environment

Windows

Browsers

  • Internet Explorer
  • Microsoft Edge
  • Google Chrome
  • FireFox
  • Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

What version of Node.js is currently installed on your workstation?

v16.16.0

What version of Node.js is required by the sample?

v16

Paste the results of SPFx doctor

There were errors when validating the App manifest.: Xml Validation Exception: 'The 'Version' attribute is invalid - The value '1.0.0' is invalid according to its datatype 'http://schemas.microsoft.com/sharepoint/2012/app/manifest:VersionDefinition' - The Pattern constraint failed.' on line '1', position '268'

Additional environment details

Updated the version to 4 integers and works perfectly, thank you for all the effort.

@BenedictCard BenedictCard added the type:bug-suspected Suspected bug (not working as designed/expected). See type:bug-confirmed for confirmed bugs label Oct 3, 2024
@BenedictCard BenedictCard changed the title Versioninf Is Incorrect Versioning Is Incorrect Oct 3, 2024
Tanddant added a commit to Tanddant/sp-dev-fx-webparts that referenced this issue Oct 9, 2024
@Tanddant
Copy link
Contributor

@BenedictCard This issue should be solved now 😊 - thanks for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-suspected Suspected bug (not working as designed/expected). See type:bug-confirmed for confirmed bugs
Projects
None yet
Development

No branches or pull requests

3 participants