Upgraded react-calendar to 1.20.0 #5331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bugs
[17:25:37] Error - [webpack] 'dist': ./node_modules/xml2js/lib/parser.js:17:17-47: Module not found: Error: Can't resolve 'timers' in 'C:\sp-dev-fx-webparts\samples\react-calendar\node_modules\xml2js\lib' BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. This is no longer the case. Verify if you need this module and configure a polyfill for it. If you want to include a polyfill, you need to: - add a fallback 'resolve.fallback: { "timers": require.resolve("timers-browserify") }' - install 'timers-browserify' If you don't want to include a polyfill, you can use an empty module like this: resolve.fallback: { "timers": false }[17:25:37] Warning - [webpack] 'dist': ./node_modules/sax/lib/sax.js:169:13-37: Module not found: Error: Can't resolve 'stream' in 'C:\react-calendar\node_modules\sax\lib' BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. This is no longer the case. Verify if you need this module and configure a polyfill for it. If you want to include a polyfill, you need to: - add a fallback 'resolve.fallback: { "stream": require.resolve("stream-browserify") }' - install 'stream-browserify' If you don't want to include a polyfill, you can use an empty module like this: resolve.fallback: { "stream": false }What's in this Pull Request?
Upgraded react-calendar to 1.20.0
Fixed issues related to xml2js NPM package
Node Version
18.19.1
Node version used: 18.19.1
Checklist
README.mdfile's Version history. For new samples, created a newREADME.mdfile matching this templateREADME.mdhas at least one static high-resolution screenshot (i.e. not a GIF) located in theassetsfolder.README.mdcontains complete setup instructions, including pre-requisites and permissions required.nvmrcfile indicating the version of Node.js