Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 not up to date #95

Open
privatenumber opened this issue Aug 28, 2023 · 6 comments
Open

v2 not up to date #95

privatenumber opened this issue Aug 28, 2023 · 6 comments

Comments

@privatenumber
Copy link

The v2 ref is not pointing to the latest release, which does not contain the latest standalone config documented in the README: https://github.com/pnpm/action-setup/tree/v2

@ekwoka
Copy link

ekwoka commented Sep 24, 2023

I'll add to this:

this repo does not have any major or minor tags, only full version tags. This is not the recommended way to handle these.

Major Versions and minor versions should be tagged and have that tag move to the latest applicable tagged release along with the full major.minor.patch versions.

So now, with 2.4.0 the tags v2 v2.4 and v2.4.0 should all be on the same commit.

This can't be done in a PR, it has to be done by someone with write permissions on the repo.

@MikeMcC399
Copy link

The branch / tag situation has improved, however the v2 branch is at the v2.3.0 release level and does not contain the latest release v2.4.0.

ID type ID commit
branch v2 0b715c7
tag v2.4.0 d882d12
tag v2.3.0 0b715c7

It looks like releases are handled in a manual way. You might like to consider automating releases so that branches and tags are automatically updated. Using https://github.com/cycjimmy/semantic-release-action is one way to do this.

@zkochan
Copy link
Member

zkochan commented Sep 27, 2023

I am sorry. I have merged master to v2 now.

@MikeMcC399
Copy link

@zkochan

I am sorry. I have merged master to v2 now.

Many thanks for correcting this! 👍🏻

@privatenumber

Would you like to check? It looks like this issue can be closed now.

@MindTooth
Copy link

MindTooth commented May 13, 2024

Still the case for both v3 and v4. The missing tags makes that e.g. Renovate Bot does not from v3 to v4.

I can help if possible.

DEBUG: github/tags.findCommitOfTag: Tag v3 not found for pnpm/action-setup
DEBUG: Could not determine new digest for update.
{
  "packageName": "pnpm/action-setup"
  "currentValue": "v3"
  "datasource": "github-tags"
  "newValue": "v3"
}

maxdeviant added a commit to zed-industries/zed that referenced this issue Jul 29, 2024
This PR upgrades the `pnpm/action-setup` GitHub Action to v4.0.0.

Trying to see if I can fix the Renovate warning stemming from
pnpm/action-setup#95.

Release Notes:

- N/A
kevmo314 pushed a commit to kevmo314/zed that referenced this issue Jul 29, 2024
This PR upgrades the `pnpm/action-setup` GitHub Action to v4.0.0.

Trying to see if I can fix the Renovate warning stemming from
pnpm/action-setup#95.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants