Let the callback result set the URL of a response #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
force-pushed
the
callback-set-url
branch
from
d6f9cab
to
e18aa95
Compare
|
I'll work on the failing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋 !
This is a cool library and we are using it for testing part of our HTTP client. One thing we needed was to be able to mock a
POST /some/form/actionthat responds with a status 302 (a few times in a row...). Depending on what you POST (correct or wrong password say) you end up being redirected somewhere else. I would like to mock this by having the response have a different URL to the request. This PR lets me do that. Is there a different way that doesn't require adding new code to the library (less code is better)?What do you think of adding something like this?