Essential fix #1 (visibility unit showing undefined)

[ArendPWS]

It is really just this fix, nothing else. I really have no idea how I would be able to clarify any further.

[poblabs]

This PR shows over 145 added lines of modified code, and 121 lines removed. Is the visibility fix really this many lines?

This is showing a lot of websocket changes, graph changes, etc.

When you commit your changes, you only need to commit the few lines that are the change and not everything. Otherwise things will become out of sync. This is why I say there's conflicts and I cannot merge.

Each change should be it's own PR and not bundled. That way it's easy to track and rollback if needed in future.

[poblabs]

With the amount of changes here, it's hard for me to see the actual change that would fix the issue. That's what my "conflict" is based off of.

[ArendPWS]

I have tried to explain that this is caused by the old code being included in the new code, that gives this weird looking result in the Github compare. There are multiple calls to ajaxweewx() which all need to modified. It is not logical to create a PR for each individual modified call.

[poblabs]

I have tried to explain that this is caused by the old code being included in the new code, that gives this weird looking result in the Github compare. There are multiple calls to ajaxweewx() which all need to modified. It is not logical to create a PR for each individual modified call.

I know why this is happening - you can include only the lined portions to submit to the PR - you don't have to include everything. That's what I've tried to explain 😄

[poblabs]

My suggestion - again - is to include only the lines that are changed and do not include the old code.

Why?

Because your PR would then re-introduce old code into the master branch effectively undo-ing a lot of work.

[ArendPWS]

No I mean it this way:

New code {
Old code
}

That is the cause of all those apparent changes.

[ArendPWS]

There is no old code in this PR

[poblabs]

Ah, it's indentation from the ajaxweewx().then(function(weewx_data) { section?

[ArendPWS]

YES!!!! Now we are getting on the same frequency 👍 Maybe now you have some idea why the compare looks the way it does 😃