Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add query script, update usage #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

jm33-m0
Copy link

@jm33-m0 jm33-m0 commented May 15, 2019

  • query.py allows users to perform image retrieval using selected algorithm
  • USAGE.md has been updated to give users instructions on image querying
  • formatted code to meet PEP8 requirements

allow users to quickly query images using selected method
and pylint-related stuff
@fifiteen82726
Copy link

fifiteen82726 commented May 15, 2019

Hi, I want to test this PR.
Is there a way to query a new image instead of the first one in the CSV file?

Like

python3 query.py resnet --search new-image

@jm33-m0
Copy link
Author

jm33-m0 commented May 15, 2019

I haven't implemented that yet, am currently working on other parts of my project.
I will add that later if you can wait.

from skimage import color
from skimage.feature import hog

from src.DB import Database

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from src.DB import Database
from DB import Database

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you do that, DB will be unable to import

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link

@fifiteen82726 fifiteen82726 May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It threw this error

$ python3 src/resnet.py
Traceback (most recent call last):
  File "src/resnet.py", line 14, in <module>
    from src.DB import Database
ModuleNotFoundError: No module named 'src'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, i have made py files under src submodules of src, thus we have to call them via src.module, outside src directory

@fifiteen82726
Copy link

I haven't implemented that yet, am currently working on other parts of my project.
I will add that later if you can wait.

Sure, it will make this project really useful.
I consider adding some setup.py

@jiaweichuang
Copy link

Hi, I want to test this PR.
Is there a way to query a new image instead of the first one in the CSV file?

Like

python3 query.py resnet --search new-image

hello,Have you implemanted this part? such as "--search new-image"

@fifiteen82726
Copy link

hello,Have you implemanted this part? such as "--search new-image"

@jiaweichuang
Hi, I've down some ugly hardcode implementation. If you want to explore it and make it extendable, I can find it and push it up.

@Praveenk8051
Copy link

@jiaweichuang push the code if you still have in the repo. I can take it from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants