Fixed issue comment finder method #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veyndan
requested changes
Mar 14, 2018
There was a problem hiding this comment.
The build has failed, can you review it?
Also as a side note, it'd be easier if converting the file to Kotlin was one commit, then the next commit was the actual change. This makes it easier to review the actual lines that have changed. You don't have to do it this time but in the future it'd be really helpful.
|
Seems like kapt can't handle AutoFactory for some reason. Gonna try to remove AutoFactory in another PR and then fix this. |
|
Well looks like there was a config to let it work. We should still try to remove AutoFactory later because I'm not sure if this kapt option is removing any compile time checks from us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments should now update in the UI when edited.