Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++17 and C11 #4235

Closed
1 task done
aleks-f opened this issue Oct 29, 2023 · 2 comments
Closed
1 task done

C++17 and C11 #4235

aleks-f opened this issue Oct 29, 2023 · 2 comments
Assignees
@aleks-f
Labels
breaking A breaking change enhancement fixed
Milestone
Release 1.13.0

Comments

@aleks-f
Copy link
Member

aleks-f commented Oct 29, 2023 •
edited
Loading

Starting with release 1.13.0, C++17 standard will be the lowest fully supported version.

What does that mean for POCO users?

  1. it will be possible to build POCO with lower versions, but without some features that require C++17
  2. given 1., all the existing user code will continue to work with new versions
  3. g++ and clang default will become -std=c++17
  4. Visual Studio 2022 default will become /std:c++17 /std:c11; older VS versions will remain as they are
@aleks-f aleks-f added the breaking A breaking change label Oct 29, 2023
@aleks-f aleks-f added this to the Release 1.13.0 milestone Oct 29, 2023
@aleks-f aleks-f self-assigned this Oct 29, 2023
aleks-f added a commit that referenced this issue Oct 29, 2023
@aleks-f
fix(LinearHashTable): fix std::iterator deprecated warnings; test war…
8c4b166 
…nings #4235
aleks-f added a commit that referenced this issue Nov 4, 2023
@aleks-f
feat: C++17 #4235
a7a6f86
@matejk
Copy link
Contributor

matejk commented Nov 8, 2023 •
edited
Loading

  1. Visual Studio 2022 default will become /std:c++17 /std:c11; older VS versions will remain as they are

Visual Studio 2019 also supports C++17. Will option /std:c++17 be enabled for that version of Visual Studio also?

@aleks-f
Copy link
Member Author

aleks-f commented Nov 9, 2023 •
edited
Loading

  1. Visual Studio 2022 default will become /std:c++17 /std:c11; older VS versions will remain as they are

Visual Studio 2019 also supports C++17. Will option /std:c++17 be enabled for that version of Visual Studio also?

we can enable it there, too. @pavledragisic is regenerating VS2022 and we will also have PS script to regenerate with one command, so it will be easy, @Bjoe promised to look over cmake buildsystem

aleks-f added a commit that referenced this issue Nov 23, 2023
@aleks-f
fix(LinearHashTable): fix std::iterator deprecated warnings; test war…
dbe7216 
…nings #4235
aleks-f added a commit that referenced this issue Nov 23, 2023
@aleks-f
feat: C++17 #4235
6f67021
aleks-f added a commit that referenced this issue Nov 27, 2023
@aleks-f
fix(LinearHashTable): fix std::iterator deprecated warnings; test war…
97e7298 
…nings #4235
aleks-f added a commit that referenced this issue Nov 27, 2023
@aleks-f
feat: C++17 #4235
b83e9d6
@aleks-f aleks-f added the fixed label Dec 21, 2023
@aleks-f aleks-f closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleks-f aleks-f

Labels
breaking A breaking change enhancement fixed
Projects
None yet
Milestone
Release 1.13.0
Development

No branches or pull requests
2 participants
@matejk @aleks-f