-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add android build on travis #1981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems all other builds are commented out?
@obiltschnig This is only to get faster an result. After android build is working I will comment all in and squash all commits. |
Wouldn't it be faster to set up Travis for your fork? |
I guess we don't need to merge this for now, as Travis builds your PR anyway ;-) |
Would be better, but travis is not building on my fork... but maybe I should create a pull request in my own fork? |
No sorry. Travis is not building in my fork. Only when I create a pull request to poco, travis builds my branch. |
@Bjoe "Travis is not building in my fork.".. Yes Travis is building your fork, but you have before to add your github repository to the travis workflow. Go on Travis and open you account. Then add your poco's fork |
82014ef
to
d5c3ddc
Compare
@zosrothko Ok thank you! Now it works. @obiltschnig Ok I cleanup/enable all builds in travis.yml and squashed my commits. At the moment the android build will fail because we have two issues in android. These are fixed in #1983 and #1975 |
11f084e
to
3566e83
Compare
febffd6
to
80c76b9
Compare
6a68f20
to
ad03198
Compare
Ok, done. Now it is ready to be merged, after review is done :-) I added two android builds. I think POCO should support as minimum API level 19 and as newest 24. These are the most distributed android platform versions. See Platform Versions There are still some open issues:
I think the problem has something to do with the standard C++ library. I will figure out what is the problem. For the first time, I decided to use the android API level 24 at runtime.
For the develop branch, should I create also a pull request? |
ad03198
to
8bb1c76
Compare
8ed6ee7
to
959197d
Compare
@Bjoe this pull should go to poco-1.9.0 |
@aleks-f Yep, I know. But I will fix first the review findings... then test should be back to green and then I will merge or better squash and rebase to poco-1.9.0. Too many changes at once could be difficult to find the problem if the build fails. So when I'm ready I will inform you. Btw. how can I requested a review? |
@aleks-f I didn't have this "button" on the right site of "Reviewers". |
I'm not sure why, you are a member of developers team and I think you should be able to: https://help.github.com/articles/requesting-a-pull-request-review/ @zosrothko can you request reviews on poco pulls with your permissions? |
@aleks-f I have read this article about "Requesting a pull request review" before and I didn't have this buttons or can search for a person. I think this is the problem:
|
f040de9
to
a0caa09
Compare
a0caa09
to
deb6d6c
Compare
deb6d6c
to
1b34af5
Compare
@zosrothko I used first POCO_ANDROID instead of POCO_OS_ANDROID, because it is not only to add POCO_OS_ANDROID in Poco/Platfrom.h... see my pull request #2186 |
* Add build for android in travis CI. * Fix review findings. Change from __ANDORID__ to POCO_ANDROID * Add android test * Fix compile issue after rebase * Ignore test big ping when its failing
* Add build for android in travis CI. * Fix review findings. Change from __ANDORID__ to POCO_ANDROID * Add android test * Fix compile issue after rebase * Ignore test big ping when its failing
* Add build for android in travis CI. * Fix review findings. Change from __ANDORID__ to POCO_ANDROID * Add android test * Fix compile issue after rebase * Ignore test big ping when its failing
Will temporarily remove/disable in 1.9.0 due to failing tests. |
Add android build on travis.