Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credit for "wmain()" wrapper #2372

Merged
merged 3 commits into from
Aug 1, 2018
Merged

Credit for "wmain()" wrapper #2372

merged 3 commits into from
Aug 1, 2018

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Jun 20, 2018 •
edited by aleks-f
Loading

@aleks-f
Copy link
Member

aleks-f commented Jun 20, 2018

@Good-Pudge can you also update documentation with mingw-specific details

@aleks-f aleks-f requested review from Bjoe and aleks-f and removed request for aleks-f June 20, 2018 14:48
@aleks-f aleks-f added this to the Release 2.0.0 milestone Jun 20, 2018
@aleks-f
Copy link
Member

aleks-f commented Jul 4, 2018

@Bjoe is this good to merge?

Bjoe
Bjoe approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@Bjoe Bjoe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review... I'm very busy with a company project :-/ .... hopefully its getting better after september .... From the cmake perspective looks fine...

Bjoe
Bjoe approved these changes Aug 1, 2018
View reviewed changes
Foundation/CMakeLists.txt
@@ -189,6 +189,7 @@ if (CMAKE_COMPILER_IS_MINGW)
WINVER=0x500
ODBCVER=0x0300
POCO_THREAD_STACK_SIZE
$<$<BOOL:BUILD_SHARED_LIBS>:_DLL>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup !! 👍

@aleks-f aleks-f merged commit 36e5121 into pocoproject:develop Aug 1, 2018
@ark0f ark0f deleted the wrapper-credit branch August 16, 2018 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleks-f aleks-f aleks-f approved these changes

@Bjoe Bjoe Bjoe approved these changes

Assignees

@ark0f ark0f

Labels
None yet
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ark0f @aleks-f @Bjoe