Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "redeclared without dllimport attribute..." warning for MinGW #2433

Merged
merged 3 commits into from
Sep 17, 2018
Merged

Fix "redeclared without dllimport attribute..." warning for MinGW #2433

merged 3 commits into from
Sep 17, 2018

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Aug 20, 2018

aleks-f
aleks-f requested changes Aug 29, 2018
View reviewed changes
CppParser/include/Poco/CppParser/CppParser.h Outdated
@@ -31,7 +31,7 @@
// CppParser_API functions as being imported from a DLL, whereas this DLL sees symbols
// defined with this macro as being exported.
//
#if (defined(_WIN32) || defined(__CYGWIN__)) && defined(POCO_DLL)
#if (defined(_MSC_VER) || defined(__CYGWIN__)) && defined(POCO_DLL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ark0f these should probably be properly checked for MSVC compiler, see #2428 why and how it was fixed in 5de2bf7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood. It will be fixed

@aleks-f
Copy link
Member

aleks-f commented Sep 4, 2018

@ark0f this tidy-up is a good effort, but it seems something caused many travis failures, those need to be taken care of before merging this

@ark0f
Use 'POCO_COMPILER_MSVC' instead of '_MSC_VER'.
afe56ea 
* Define 'POCO_COMPILER_MINGW' with 'POCO_COMPILER_GCC' too
@ark0f
Copy link
Member Author

ark0f commented Sep 5, 2018 •
edited
Loading

Thank you. I know about Travis. I see that jobs were interrupted and I can't view full logs as it are more than 4 MB (Travis log limit). I can use git commit --amend to restart build totally.

@ark0f
Copy link
Member Author

ark0f commented Sep 8, 2018

Restart didn't give result.

@ark0f
Copy link
Member Author

ark0f commented Sep 8, 2018

Hm... I see that Clang produce many warnings unused typedef. I'll try to fix it.

@ark0f
Copy link
Member Author

ark0f commented Sep 8, 2018

@aleks-f, I think we need to refactor POCO_COMPILER_CLANG definition to avoid problems with using POCO_COMPILER_GCC instead of __GNUC__ as Clang is GCC-like compiler (like MinGW).

@aleks-f aleks-f merged commit 223ce27 into pocoproject:develop Sep 17, 2018
@motxx motxx mentioned this pull request Feb 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleks-f aleks-f aleks-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ark0f @aleks-f