Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DNSSD into main Poco #4323

Closed
wants to merge 33 commits into from
Closed

Conversation

soroshsabz
Copy link
Contributor

ITNOA

Merge DNSSD into main Poco project

fixes #2208

@soroshsabz
Copy link
Contributor Author

@aleks-f @matejk as you say, I create new PR, so please start CI

thanks

Copy link
Member

@aleks-f aleks-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need only vs_90, vs_160 and vs_170 projects here (see #4274). all others should be deleted, and vs_160 and vs_170 generated with progen

@geirhei
Copy link

geirhei commented Feb 2, 2024

Any progress on this @soroshsabz? The library is very useful, would be great to get it into POCO.

@soroshsabz
Copy link
Contributor Author

@aleks-f I am done

please run CI

thanks

@soroshsabz soroshsabz requested a review from aleks-f February 25, 2024 17:16
@soroshsabz
Copy link
Contributor Author

@matejk

@matejk
Copy link
Contributor

matejk commented Feb 26, 2024

I don't know why only a few of the CI jobs were executed and not all of them.

DNSSD/Bonjour/Bonjour_vs100.vcxproj Outdated Show resolved Hide resolved
ActiveRecord/ActiveRecord_vs170.vcxproj Outdated Show resolved Hide resolved
DNSSD/DNSSD_vs90.vcproj Show resolved Hide resolved
@soroshsabz
Copy link
Contributor Author

@aleks-f I resolve all your notes

please run CI

@soroshsabz soroshsabz requested a review from aleks-f February 29, 2024 09:47
@aleks-f aleks-f mentioned this pull request Mar 1, 2024
@aleks-f
Copy link
Member

aleks-f commented Mar 1, 2024

#4479

@soroshsabz
Copy link
Contributor Author

soroshsabz commented Mar 28, 2024

@aleks-f

I am happy to reopen this PR and merge that PR

thanks

@soroshsabz soroshsabz mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Poco DNSSD to Poco
5 participants