JSONConfiguration in Poco::Util::Application

[naquin]

I have added JSONConfiguration to Poco::Util::Application::loadConfiguration. This seems to be a reasonable extension since JSONConfiguration was already implemented.

I also added a corresponding POCO_UTIL_NO_JSONCONFIGURATION macro along the lines of POCO_UTIL_NO_XMLCONFIGURATION and POCO_UTIL_NO_INIFILECONFIGURATION.

Please let me know if this is a good idea or not. Thanks!

[obiltschnig]

sounds good to me

-guenter

Günter Obiltschnig
Applied Informatics Software Engineering GmbH
A-9182 Maria Elend | Maria Elend 96/4 | www.appinf.com
P: +43 4253 32596 M: +43 676 5166737 F: +43 4253 32096

Company Registration: FN 276491 f | Landesgericht Klagenfurt
Managing Director: DI Günter Obiltschnig

On 13.11.2012, at 22:46, syvex wrote:

I have added JSONConfiguration to Poco::Util::Application::loadConfiguration. This seems to be a reasonable extension since JSONConfiguration was already implemented.

I also added a corresponding POCO_UTIL_NO_JSONCONFIGURATION macro along the lines of POCO_UTIL_NO_XMLCONFIGURATION and POCO_UTIL_NO_INIFILECONFIGURATION.

Please let me know if this is a good idea or not. Thanks!

You can merge this Pull Request by running:

git pull https://github.com/syvex/poco JSONConfiguration
Or view, comment on, or merge it at:

#7

Commit Summary

• Add JSONConfiguration to Poco::Util::Application::loadConfiguration.
• Update description for POCO_UTIL_NO_JSONCONFIGURATION
File Changes

• M Foundation/include/Poco/Config.h (6)
• M Util/src/Application.cpp (12)
• M configure (2)
Patch Links

• https://github.com/pocoproject/poco/pull/7.patch
• https://github.com/pocoproject/poco/pull/7.diff
—
Reply to this email directly or view it on GitHub.

[aleks-f]

it is a good idea;however, to build Util without JSON, the JSONConfiguration itself should be #idef'd as well. can you please do that as well?

[aleks-f]

additionally, please fork code off the develop branch (not release)

see this model, that's what we use:

http://nvie.com/posts/a-successful-git-branching-model/

this page is also helpful to stay synced with what's going on with poco:

https://github.com/pocoproject/poco/network

[aleks-f]

And, when I look better, XML and INI configurations are not #ifdef'd as well.
Günter: is there a reason for it? It doesn't seem to make sense to compile them in and then strip them off Application

[obiltschnig]

The reason why it's only stripped off Application and not the entire Util library is that when building for smaller embedded Linux systems, we generally link statically. Therefore, it does not hurt if XMLConfiguration gets compiled into the library. It only hurts if it's referenced by Application, because if so, as soon as Application or ServerApplication is used, the entire XML library gets pulled in. This allows us to keep final application binary size around 2MB (when combined with the other --poquito left outs). Back when I did this I did not care about shared libraries, or whether XMLConfiguration actually is in the library. It was just being referenced by Application that mattered.

Günter

Günter Obiltschnig
Applied Informatics Software Engineering GmbH
A-9182 Maria Elend | Maria Elend 96/4 | www.appinf.com
P: +43 4253 32596 M: +43 676 5166737 F: +43 4253 32096

Company Registration: FN 276491 f | Landesgericht Klagenfurt
Managing Director: DI Günter Obiltschnig

On 14.11.2012, at 00:55, Aleksandar Fabijanic wrote:

And, when I look better, XML and INI configurations are not #ifdef'd as well.
Günter: is there a reason for it? It doesn't seem to make sense to compile them in and then strip them off Application

—
Reply to this email directly or view it on GitHub.

[aleks-f]

I understand. I still think it would be good to strip them all out. Quite often, I find the Util dependency on XML and JSON annoying. Any objections to that?

[obiltschnig]

No objections

-guenter

Günter Obiltschnig
Applied Informatics Software Engineering GmbH
A-9182 Maria Elend | Maria Elend 96/4 | www.appinf.com
P: +43 4253 32596 M: +43 676 5166737 F: +43 4253 32096

Company Registration: FN 276491 f | Landesgericht Klagenfurt
Managing Director: DI Günter Obiltschnig

On 14.11.2012, at 14:32, Aleksandar Fabijanic wrote:

I understand. I still think it would be good to strip them all out. Quite often, I find the Util dependency on XML and JSON annoying. Any objections to that?

—
Reply to this email directly or view it on GitHub.

[naquin]

I will see about putting a separate #ifdef around the XMLConfiguration and JSONConfiguration files then. This should help avoid some confusion on what gets linked in by the application.

[aleks-f]

ok. I'll close this pull request. please fork off the develop branch and send pull request back.