Allow for dynamic values for URL.URLValue #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…URL.URLValue` umm record
nikki-t
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Looks good to me. I agree that this will unblock podaac/hydrocron#77 and podaac/hydrocron#109.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url_valueoptional input to this action. If not given, defaults to environment specific harmony url. If provided, value will be substituted in theURL.URLValueproperty of the umm record specifiedI believe this will unblock podaac/hydrocron#77, podaac/hydrocron#109
Docker image builds successfully: https://github.com/podaac/hydrocron/actions/runs/8486723196
Unfortunately I don't think I can test the changes until we have a record in UAT to try it with