Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update error logging #138

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Feature/update error logging #138

merged 8 commits into from
Dec 6, 2024

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Dec 6, 2024

Description

  • Add in concise exception for harmony
  • Update python libraries

Overview of work done

  • Added concise exception class inherit from harmony exception so that we know more about the error in harmony api calls instead of a generic error message
  • Update python libraries for concise

Overview of verification done

  • Tested on local harmony to make sure everything still works

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@sliu008 sliu008 requested a review from jamesfwood December 6, 2024 18:23
jamesfwood
jamesfwood approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@jamesfwood jamesfwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jamesfwood jamesfwood merged commit dcbfbb6 into develop Dec 6, 2024
3 checks passed
@jamesfwood jamesfwood deleted the feature/update_error_logging branch December 6, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesfwood jamesfwood jamesfwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliu008 @jamesfwood