Issue 4: Fixed bug where VariableInfo equality fails when _FillValue is np.nan #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #4
Description
The granule variable equality check is failing for the granules tested in #4. This leads to
Overview of work done
Because of the following:
we are seeing errors if the
_FillValueis np.nan, because the equality check fails. Added an extra check if the equality check failsOverview of verification done
_FillValue= np.nan caseOverview of integration done
N/A
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request