Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added error messages for malformed and missing key in .harmony file to fix issue #168 #170

Merged
merged 4 commits into from
May 9, 2024

Conversation

avvalenx
Copy link

@avvalenx avvalenx commented May 2, 2024

Please let me know if any more information is needed

@skorper skorper changed the base branch from main to develop May 2, 2024 18:29
Copy link
Contributor

@skorper skorper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution, @avvalenx ! Can you add a new entry to the Unreleased section of the changelog describing your changes?

@avvalenx
Copy link
Author

avvalenx commented May 2, 2024

You're welcome @skorper! I added the changes to the unreleased section of the changelog. Please let me know if anything else is needed or if this was done incorrectly. Thank you.

@skorper
Copy link
Contributor

skorper commented May 2, 2024

@avvalenx Looks great, thank you! There is a conflict now, can you resolve that before I merge? Thanks again!

@avvalenx
Copy link
Author

avvalenx commented May 2, 2024

Yes conflict is resolved @skorper

@avvalenx
Copy link
Author

avvalenx commented May 3, 2024

@skorper what happened with these checks? Is this something I did wrong? I pulled from the main branch instead of development would that have an effect? Let me know if there is anything I can do to assist.

@skorper
Copy link
Contributor

skorper commented May 9, 2024

@avvalenx I think the build is failing because the secrets needed to run the regression tests are not present in your fork. I will go ahead and merge without the regression tests passing, since it's a simple enough change. Thanks again for your contribution!

@skorper skorper merged commit d6953f2 into podaac:develop May 9, 2024
1 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants