Feature/adjust time function #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesfwood
reviewed
Jun 25, 2024
deployment/harmony_deploy.py
Outdated
| parser.add_argument("--tag", help="The new tag version to update.", required=True) | ||
| args = parser.parse_args() | ||
|
|
||
| url = f"https://harmony.{'uat.' if ENV == 'uat' else ''}earthdata.nasa.gov/service-image-tag/#podaac-l2-subsetter" |
There was a problem hiding this comment.
If this doesn't work, trying taking out the "#". I've always ran it without the # in the url.
jamesfwood
approved these changes
Jun 25, 2024
podaac/subsetter/subset.py
Outdated
| # then check if any variables have 'time' in the string if the above loop doesn't return anything | ||
| for var_name in list(dataset.data_vars.keys()): | ||
| var_name_time = var_name.strip(GROUP_DELIM).split(GROUP_DELIM)[-1] | ||
| if len(dataset[var_name].squeeze().dims) == 0: | ||
| continue | ||
| if var_name not in total_time_vars and 'time' in var_name_time.lower() and dataset[var_name].squeeze().dims[0] in lat_var.squeeze().dims: | ||
| print(var_name) |
There was a problem hiding this comment.
change to a log call or remove
frankinspace
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update l2ss-py to remove warnings and better get the time variable
Overview of work done
Overview of verification done
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request