-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMS-2590 fix: use 'resources' tag for PATCH /domains/:domain_id #11
HMS-2590 fix: use 'resources' tag for PATCH /domains/:domain_id #11
Conversation
Could you please change the commit message and PR to reflect the details of the change, while focusing on relevant changes? The fact only that Also use upper-case letters for title reference
|
@tiran thanks mate! updated! |
You updated the ticket description, but not the commit message that will land in git. The commit message is IMHO more important than the ticket description. After all the information ends up in the commit history. A sentence or two is more than sufficient for a trivial change. The change doesn't even affect the backend. |
6699a87
to
7406afb
Compare
@tiran thanks mate! I didn't realize about the commit message; now it is updated. |
I hate do be pedantic ... but you didn't read my last comment, did you? :) Now the commit message is overly long and goes into unimportant details. In my opinion and experience, commit messages should provide a short overview of the "what" and "why" of the change set. They should be as long as necessary and as short as possible. For this PR, one sentence, maybe two are more than sufficient. Personally I would not even include an explanation, because the change does not have an impact on the behavior of the backend. It only updates the serialized JSON string of the schema. |
7406afb
to
3521ba3
Compare
Update the generated spec.gen.go file after the new API has been attached. Signed-off-by: Alejandro Visiedo <avisiedo@redhat.com>
3521ba3
to
00cffc8
Compare
thanks mate! at the beginning I understood it was the PR message; later I updated the commit message; I have updated with a short description. 👍 |
Update the generated spec.gen.go file after the new API has been attached.