Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PodioLogger.php fix #225

Merged
merged 2 commits into from
Jun 12, 2023
Merged

PodioLogger.php fix #225

merged 2 commits into from
Jun 12, 2023

Conversation

mgithens
Copy link
Contributor

Need to check if the directory already exists.

@mgithens
Update PodioLogger.php
0036e1a 
Need to check if the directory already exists.
rafaelmb
rafaelmb approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@rafaelmb rafaelmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daniel-sc
daniel-sc approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@daniel-sc daniel-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgithens thanks, this is an improvement to the current code. If you could address my comment it could possibly improve even more :) (change or explain)

lib/PodioLogger.php Outdated Show resolved Hide resolved
@daniel-sc daniel-sc merged commit b380135 into podio-community:master Jun 12, 2023
@daniel-sc daniel-sc linked an issue Jun 12, 2023 that may be closed by this pull request
/podio-community/podio-php/lib/error/PodioError.php missing public $request declaration #223
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelmb rafaelmb rafaelmb approved these changes

@daniel-sc daniel-sc daniel-sc approved these changes

@carlfredrikhero carlfredrikhero Awaiting requested review from carlfredrikhero

@bajarang-agarwal bajarang-agarwal Awaiting requested review from bajarang-agarwal

@timosillander timosillander Awaiting requested review from timosillander

@dylannadon dylannadon Awaiting requested review from dylannadon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/podio-community/podio-php/lib/error/PodioError.php missing public $request declaration
3 participants
@mgithens @daniel-sc @rafaelmb