Require guzzlehttp/psr7 >= 1.7.0 for Util class #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PodioClient class depends on the `\GuzzleHttp\Psr7\Utils` class, however this was not included in the existing requirements, since the `guzzlehttp/guzzle` requirement of `>=6.2.0` only requires `guzzlehttp/psr7:~1.1`, so this will cause a "Class not found" error when attempting to load the Util class.
daniel-sc
requested review from
daniel-sc,
carlfredrikhero,
rafaelmb,
bajarang-agarwal,
timosillander and
dylannadon
|
@toby-griffiths Thanks for the contribution! IMHO it might be cleaner to increase the guzzle version but the other way is fine as well. |
daniel-sc
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PodioClient class depends on the
\GuzzleHttp\Psr7\Utilsclass, however this was not included in the existing requirements, since theguzzlehttp/guzzlerequirement of>=6.2.0only requiresguzzlehttp/psr7:~1.1, so this will cause a "Class not found" error when attempting to load the Util class.This change explicitly adds the
guzzlehttp/psr7:>=1.7.0requirement, however this could also be acheived by bumping theguzzlehttp/guzzlerequirement, since anything less than6.5.8has a security vulnerability.