This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Edits done for pTray #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 20, 2014 12:17
Conversation modified;
| public List<Conversation> getConversations() { | ||
| WebResource resource = getResourceFactory().getApiResource( | ||
| "/conversation/"); | ||
| resource=resource.queryParam("limit","15"); |
There was a problem hiding this comment.
This limit should at least be optional ?
There was a problem hiding this comment.
Yes, you should add a parameter to the method of type Integer, and add it to the resource if it is != null.
|
I ll work on it, will fix it when catch some time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications done for pTray.
Mostly worked on Notifications, Conversations. Goal was to get more specific information about specific items.