fix: Consume body on non 200 requests #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trygve-lie
requested review from
leftieFriele,
wkillerud,
benja and
tor0405
and removed request for
benja
digitalsadhu
approved these changes
Dec 1, 2023
|
🎉 This PR is included in version 5.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically this should fix the
SocketError: other side closederrors we are seeing.Based on the theory that the body of a request must be consumed or destroyed it seems to me that for requests which yield a HTTP 200 (successful) response we are consuming the body while for request which yields a non HTTP 200 (unsuccessful) response we are not.
Non HTTP 200 responses do have a body too.
This consumes the body on non HTTP 200 responses. Consuming the body over destroying the stream is done because destroying the stream will trigger a socket error which causes a termination of the request differently that what we want when the upstream service is yielding http errors.