GH95 | error is not returned when mic access is blocked (twilio#144)

* GH95 | error is not returned when mic access is blocked

* PR Review

CHANGELOG.md

@@ -1,3 +1,11 @@
+2.3.2 (In Progress)
+===================
+
+Bug Fixes
+---------
+
+- Fixed an [issue](https://github.com/twilio/twilio-voice.js/issues/95) where a Twilio error is not returned when microphone access is blocked. Thank you @SiimMardus and @ostap0207 for your [contribution](https://github.com/twilio/twilio-voice.js/pull/143).
+
 2.3.1 (February 3, 2023)
 ===================
 

lib/twilio/device.ts

@@ -982,6 +982,10 @@ class Device extends EventEmitter {
  }, options);
 
  const maybeUnsetPreferredUri = () => {
+ if (!this._stream) {
+ this._log.warn('UnsetPreferredUri called without a stream');
+ return;
+ }
  if (this._activeCall === null && this._calls.length === 0) {
  this._stream.updatePreferredURI(null);
  }

tests/unit/device.ts

@@ -813,6 +813,16 @@ describe('Device', function() {
  device.calls[0].emit('error');
  sinon.assert.calledOnce(spyIncomingSound.stop);
  });
+
+ it('should not unset the preferred uri if stream is null', () => {
+ const spy: any = device['_stream'].updatePreferredURI =
+ sinon.spy(device['_stream'].updatePreferredURI);
+
+ device['_stream'] = null;
+ device.calls[0].status = () => CallType.State.Closed;
+ device.calls[0].emit('error');
+ sinon.assert.notCalled(spy);
+ });
  });
 
  describe('on call.transportClose', () => {