refactor(stripe): Use PaymentIntent and subscriptions instead of Checkout sessions #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added endpoint to create stripe subscriptions - Add services to: Create stripe products Create stripe customers Create stripe subscriptions
This is where it should belong
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
Needed for creating wishes after payment has been made
1 task
sashko9807
changed the title
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
slavcho
approved these changes
Aug 31, 2024
| @@ -36,7 +36,7 @@ export function getPaymentData( | |||
| charge?: Stripe.Charge, | |||
| ): PaymentData { | |||
| const isAnonymous = paymentIntent.metadata.isAnonymous === 'true' | |||
|
|
|||
| console.log(charge?.payment_method_details?.card?.country) | |||
There was a problem hiding this comment.
This seems like a leftover.
| @@ -63,6 +63,7 @@ export function getPaymentData( | |||
|
|
|||
| export function getPaymentDataFromCharge(charge: Stripe.Charge): PaymentData { | |||
| const isAnonymous = charge.metadata.isAnonymous === 'true' | |||
| console.log(charge?.payment_method_details?.card?.country) | |||
|
|
||
| let metadata: DonationMetadata = { | ||
| Logger.log('[ handleInvoicePaid ]', invoice) | ||
| const charge = await this.stripeService.findChargeById(invoice.charge as string) |
There was a problem hiding this comment.
We are using this variable 30 lines below.
Can we move this line closer to:
const paymentData = getInvoiceData(invoice, charge)
|
There are some conflicts to be resolved however... |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #473 #466
Motivation and context
Continuation of #479
-Replaced current implementation of Stripe.Checkout Sessions with Stripe's PaymentIntent and Subscriptions APIs.
-Refactored the donation module. Removed any logic not related to donations(e.g. payment provider logic), and moved it to its own module.