add findAll and findOne for admin only usage #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
requested changes
Aug 18, 2024
| isAdminFlag = false | ||
| } else { | ||
| isAdminFlag = true | ||
| } |
There was a problem hiding this comment.
No need for the isAdminFlag. isAdmin already returns a boolean.
You can just do const isAdmin = isAdmin(user) and pass isAdmin to the the findOne service.
| throw new NotFoundException('No person found in database') | ||
| } | ||
| let isAdminFlag | ||
| if (!isAdmin(user)) { |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
sashko9807
requested changes
Aug 26, 2024
| @@ -18,6 +18,7 @@ describe('CampaignApplicationController', () => { | |||
| let controller: CampaignApplicationController | |||
| let service: CampaignApplicationService | |||
| let personService: PersonService | |||
| const { isAdmin } = require('../auth/keycloak') | |||
There was a problem hiding this comment.
Use the ES6 import import {isAdmin} from ../auth/keycloak`, over the require() statement
sashko9807
reviewed
Aug 27, 2024
| } | ||
| } | ||
|
|
||
| async findOne(id: string, isAdminFlag: boolean, person: Person) { |
There was a problem hiding this comment.
A bit ugly but set the type of the person argument to be
Prisma.PersonGetPayload<{ include: { organizer: {select:{id:true}}}}>instead of Person to prevent the linter complaint. Also make sure that organizer.id is optional(e.g. person.organizer?.id)
sashko9807
reviewed
Aug 27, 2024
| } | ||
|
|
||
| findOne(id: string) { | ||
| return `This action returns a #${id} campaignApplication` | ||
| async deleteFile(id: string, isAdminFlag: boolean, person: Person) { |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
sashko9807
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.