Email send task #665
Email send task #665
Conversation
when new campaign application is added the organizer will receive an email
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
| @Injectable() | ||
| export class CampaignApplicationService { | ||
| private readonly bucketName: string = 'campaignapplication-files' | ||
| constructor( | ||
| private prisma: PrismaService, | ||
| private organizerService: OrganizerService, | ||
| private s3: S3Service, | ||
| private sendEmail: EmailService, |
There was a problem hiding this comment.
please rename to sendEmail to emailService
| person: Person, | ||
| ) { | ||
| const userEmail = { to: [person.email] as EmailData[] } | ||
| const adminEmail = { to: ['campaign_coordinators@podkrepi.bg'] as EmailData[] } |
There was a problem hiding this comment.
Would probably be better to put campaign_coordinators@podkrepi.bg into env, as it might be used in other places in the future. Something like CAMPAIGN_COORDINATOR_EMAIL would do I suppose
|
|
||
| await this.sendEmail.sendFromTemplate(mailAdmin, adminEmail, { | ||
| bypassUnsubscribeManagement: { enable: true }, | ||
| }) |
There was a problem hiding this comment.
I don't see any reason to await sending the emails, since they are not urgent for the response, and are allowed to happen with some delay. Though if there is any valid reason you can do it concurrently with Promise.allSettled, instead of doing it sequential, since neither of the promises are depended by the result of the another one.
Example:
const userEmailPromise = this.sendEmail.sendFromTemplate(mailOrganizer, userEmail, {
bypassUnsubscribeManagement: { enable: true },
})
const adminEmailPromise = this.sendEmail.sendFromTemplate(mailAdmin, adminEmail, {
bypassUnsubscribeManagement: { enable: true },
})
await Promise.allSettled([userEmailPromise, adminEmailPromise])…aignApplication method
sashko9807
force-pushed
the
emailSendTask
branch
from
df4319f
to
ab3dbdf
Compare
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
No description provided.