fix: Sendgrid can't create list if name is too long #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Not all tests have run for this PR. Please add the |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
slavcho
approved these changes
Sep 30, 2024
| @@ -0,0 +1,21 @@ | |||
| export function truncateNameToBytes(name: string, maxBytes: number) { | |||
| const encoder = new TextEncoder() | |||
There was a problem hiding this comment.
can we add some comments about what do those Encoders do?
I guess this does something like utf8 to bytes... and whole play is not to cut in the middle of a symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sendgrid's contact list name limit, is towards bytes, not a num of characters.
Closes #1914