Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: campaign type and add files #670

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: campaign type and add files #670

wants to merge 2 commits into from

Conversation

gparlakov
Copy link
Contributor

@gparlakov gparlakov commented Sep 7, 2024 •
edited
Loading

  • add files to the campaign application findOne
  • replace category with campaignTypeId (category is a property of the campaignType and was used incorrectly to define it)
  • add campaign end ( end type + date if applicable)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

✅ Tests will run for this PR. Once they succeed it can be merged.

@gparlakov gparlakov force-pushed the include-files-in-campaign-application-response branch 2 times, most recently from dda0a7d to 2698a7b Compare September 9, 2024 09:47
@gparlakov
fix: campaign type and add files
3a6b125 
- add files to the campaign application findOne
- replace category with campaignTypeId (category is a property of the campaignType and was used incorrectly to define it)
- linting fixes
@gparlakov
fix: add campaign end
733f741 
- add campaign end type and date
@gparlakov gparlakov force-pushed the include-files-in-campaign-application-response branch from 2698a7b to 733f741 Compare September 11, 2024 03:18
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Sep 13, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gparlakov @sashko9807