feat: create a protected route for campaign applications (Epic #1842) #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
requested changes
Jun 18, 2024
| import Layout from '../layout/Layout' | ||
|
|
||
| export default function CampaignApplicationPage() { | ||
| return <Layout></Layout> |
There was a problem hiding this comment.
This line doesn't pass the linter self-closing rule. Can you change it to <Layout/> or add some child element to it.
There was a problem hiding this comment.
Made it self-closing as I have already started working on another branch where I am adding the children elements.
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
sashko9807
approved these changes
Jun 18, 2024
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-frontend
that referenced
this pull request
Jun 19, 2024
…pi-bg#1842) (podkrepi-bg#1855) * create a protected route for campaign applications * fix: self-closing tag linter error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new protected route for campaign applications connected to Epic #1842
Testing
Steps to test
http://localhost:3040/campaigns/application