Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file name formating before render, tooltip added for full file name #1940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viiktorstefanov
Copy link
Contributor

Closes #issue-1918

Motivation and context

Screenshots:

Screenshot 2024-09-18 at 14-32-08 Подкрепи бг
Screenshot 2024-09-18 at 14-31-28 Подкрепи бг

Before After
Paste screenshot Paste screenshot

Testing

Steps to test

Affected urls

Environment

New environment variables:

  • NEW_ENV_VAR: env var details

New or updated dependencies:

Dependency name Previous version Updated version Details
dependency/name v1.0.0 v2.0.0

Copy link

github-actions bot commented Sep 18, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

@gparlakov gparlakov added the run tests Allows running the tests workflows for forked repos label Oct 19, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Oct 19, 2024
Copy link
Member

@ani-kalpachka ani-kalpachka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we just add space around the file name and save the current design. Do we need to include a tooltip? If you suggest this approach we may sync it with the design team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants