This repository has been archived by the owner on May 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #416 from podlove/development
Release 4.0.0-alpha.6
- Loading branch information
Showing
364 changed files
with
8,586 additions
and
6,915 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,195 @@ | ||
<a name="4.0.0-alpha"></a> | ||
# [4.0.0-alpha](https://github.com/podlove/podlove-web-player/compare/v4.0.0-alpha.5...v4.0.0-alpha) (2017-07-10) | ||
|
||
|
||
### Bug Fixes | ||
|
||
* **chapters:** Fixing various bugs related to chapters control ([2d5e061](https://github.com/podlove/podlove-web-player/commit/2d5e061)), closes [#390](https://github.com/podlove/podlove-web-player/issues/390) [#389](https://github.com/podlove/podlove-web-player/issues/389) | ||
* **linting:** fix linter errors ([311f324](https://github.com/podlove/podlove-web-player/commit/311f324)) | ||
* **play-button:** Dynamic width play button with text mode ([778fc03](https://github.com/podlove/podlove-web-player/commit/778fc03)) | ||
|
||
|
||
### Features | ||
|
||
* **chapter:** Add hover effect to chapters ([6bdb5ae](https://github.com/podlove/podlove-web-player/commit/6bdb5ae)) | ||
* **chapters:** Rework chapter interaction, introduce play icon in chapter ([9e17747](https://github.com/podlove/podlove-web-player/commit/9e17747)) | ||
* **chapters:** Start chapter on touch always from beginning ([6997b64](https://github.com/podlove/podlove-web-player/commit/6997b64)) | ||
* **chapters:** Use chapter entries to navigate through playtime ([1fbd4bf](https://github.com/podlove/podlove-web-player/commit/1fbd4bf)) | ||
* **chapters:** Use chapter entries to navigate through playtime ([847d69b](https://github.com/podlove/podlove-web-player/commit/847d69b)) | ||
* **error-monitor:** Add sentry support with release control ([58ea3c7](https://github.com/podlove/podlove-web-player/commit/58ea3c7)) | ||
* **font-face:** Use Fira sans and Fira mono ([935a132](https://github.com/podlove/podlove-web-player/commit/935a132)) | ||
* **ghost-chapter:** Add ghost mode to chapters ([0202f50](https://github.com/podlove/podlove-web-player/commit/0202f50)) | ||
* **info:** Set links in embed mode ([05b8778](https://github.com/podlove/podlove-web-player/commit/05b8778)) | ||
* **keyboard:** Add keyboard effects to control volume ([ba7b88b](https://github.com/podlove/podlove-web-player/commit/ba7b88b)) | ||
* **playtime:** Prefix running progress and chapters with minus ([ae23ba2](https://github.com/podlove/podlove-web-player/commit/ae23ba2)) | ||
* **progress-track:** Add ghost mode to progress slider ([401c032](https://github.com/podlove/podlove-web-player/commit/401c032)) | ||
* **settings-tab:** Add mute/unmute button ([df9eafd](https://github.com/podlove/podlove-web-player/commit/df9eafd)) | ||
* **settings-tab:** Add mute/unmute button ([8aacb7b](https://github.com/podlove/podlove-web-player/commit/8aacb7b)) | ||
* **speed-slider:** Use two linear functions for better speed sliding ([c37ef85](https://github.com/podlove/podlove-web-player/commit/c37ef85)) | ||
* **tab-refinement:** Update color calculation to match also highly saturated colours. ([cec77fb](https://github.com/podlove/podlove-web-player/commit/cec77fb)) | ||
|
||
|
||
### BREAKING CHANGES | ||
|
||
* **tab-refinement:** - theme.primary is now called theme.main | ||
- theme.secondary is now called theme.highlight | ||
|
||
|
||
|
||
<a name="4.0.0-alpha"></a> | ||
# [4.0.0-alpha](https://github.com/podlove/podlove-web-player/compare/v4.0.0-alpha.5...v4.0.0-alpha) (2017-06-16) | ||
|
||
|
||
### Bug Fixes | ||
|
||
* Close breakpoint gap in titlebar views ([189121f](https://github.com/podlove/podlove-web-player/commit/189121f)) | ||
* Convert absolute bg image path to relative ([e24af7e](https://github.com/podlove/podlove-web-player/commit/e24af7e)) | ||
* **style:** Apply strict word-break rule only on links in tabs ([61969bd](https://github.com/podlove/podlove-web-player/commit/61969bd)) | ||
* prevent long words from breaking out of layout ([eedd890](https://github.com/podlove/podlove-web-player/commit/eedd890)) | ||
* **babelrc:** Fix invalid runtime configuration ([d309623](https://github.com/podlove/podlove-web-player/commit/d309623)) | ||
* **baseurl:** Provide base url as asset base ([3052775](https://github.com/podlove/podlove-web-player/commit/3052775)) | ||
* **Buttons:** Remove multiple podlove-player--button occasions ([100e041](https://github.com/podlove/podlove-web-player/commit/100e041)), closes [#334](https://github.com/podlove/podlove-web-player/issues/334) | ||
* **Current Chapter:** Calculate minima; width of current chapter ([e0220e5](https://github.com/podlove/podlove-web-player/commit/e0220e5)), closes [#337](https://github.com/podlove/podlove-web-player/issues/337) [#339](https://github.com/podlove/podlove-web-player/issues/339) | ||
* **gh-pages:** Disable GitHub pages temporary ([39dad23](https://github.com/podlove/podlove-web-player/commit/39dad23)) | ||
* **github-releases:** Provide all files, also some minor adjustments to bundling and styling ([4794704](https://github.com/podlove/podlove-web-player/commit/4794704)) | ||
* **layout:** Fix adaptive font-sizes for large screens ([01f27e3](https://github.com/podlove/podlove-web-player/commit/01f27e3)) | ||
* **layout:** Fix overlapping breakpoints for small screens ([5ec57d3](https://github.com/podlove/podlove-web-player/commit/5ec57d3)) | ||
* **layout:** One column in info tab on small screens ([423b978](https://github.com/podlove/podlove-web-player/commit/423b978)) | ||
* **persist:** Fixes issue with object-hash library, use hashed title as identifier ([32f8a75](https://github.com/podlove/podlove-web-player/commit/32f8a75)) | ||
* **publisher-integration:** Several adaptions for web player integration ([546ea4a](https://github.com/podlove/podlove-web-player/commit/546ea4a)) | ||
* **slider-thumbs:** Desktop-clicking the timeline is not precise #366 ([635f225](https://github.com/podlove/podlove-web-player/commit/635f225)) | ||
* **Steppers:** Enforce float on state ([44edf26](https://github.com/podlove/podlove-web-player/commit/44edf26)), closes [#338](https://github.com/podlove/podlove-web-player/issues/338) | ||
* **Steppers:** Steppers wrong state while playing ([c05ecde](https://github.com/podlove/podlove-web-player/commit/c05ecde)), closes [#336](https://github.com/podlove/podlove-web-player/issues/336) | ||
* **style:** Add margin to info tab paragraphs ([05bec1d](https://github.com/podlove/podlove-web-player/commit/05bec1d)) | ||
* **style:** Apply normal word-break rule on p and headings in tabs ([8c2ed7a](https://github.com/podlove/podlove-web-player/commit/8c2ed7a)) | ||
* use general margin variable for progress bar margins ([6b8a352](https://github.com/podlove/podlove-web-player/commit/6b8a352)) | ||
* **style:** Fix alignment of elements in progress bar ([b57cde6](https://github.com/podlove/podlove-web-player/commit/b57cde6)) | ||
|
||
|
||
### Features | ||
|
||
* **improve-bundling:** Streamline .babelrc, adjust tests ([165cb61](https://github.com/podlove/podlove-web-player/commit/165cb61)) | ||
* add margin left and right to progress bar so that progress handle / scrubber is completely shown when progess is 0% or 100% ([1016428](https://github.com/podlove/podlove-web-player/commit/1016428)) | ||
* **bundling:** Improve bundling ([243f09a](https://github.com/podlove/podlove-web-player/commit/243f09a)) | ||
* **deep-linking:** Use podlove deep linking format ([9df558c](https://github.com/podlove/podlove-web-player/commit/9df558c)) | ||
* **error-handling:** Handle player load error ([be9ee00](https://github.com/podlove/podlove-web-player/commit/be9ee00)) | ||
* **keyboard:** Add keyboard effects ([3957b23](https://github.com/podlove/podlove-web-player/commit/3957b23)) | ||
* **l10n:** Add Internationalisation ([3908225](https://github.com/podlove/podlove-web-player/commit/3908225)) | ||
* **loader:** Animate opacity on boot time ([e7a37f8](https://github.com/podlove/podlove-web-player/commit/e7a37f8)) | ||
* **quantiles:** Only track the users played section ([3b73bd3](https://github.com/podlove/podlove-web-player/commit/3b73bd3)) | ||
* **seperation:** Separate docs and statics ([a6b2e0e](https://github.com/podlove/podlove-web-player/commit/a6b2e0e)) | ||
* **settings-tab:** Add mute/unmute button ([8aacb7b](https://github.com/podlove/podlove-web-player/commit/8aacb7b)) | ||
* use pointer cursor on progress handle / scrubber ([72bf499](https://github.com/podlove/podlove-web-player/commit/72bf499)) | ||
* **share-link:** Use a share link ([a2b3fef](https://github.com/podlove/podlove-web-player/commit/a2b3fef)) | ||
* **share-tab:** Adapt sharing UI, buttons for volume slider ([60b3f72](https://github.com/podlove/podlove-web-player/commit/60b3f72)) | ||
* **speed-slider:** Improve Speed Slider ([7249b0b](https://github.com/podlove/podlove-web-player/commit/7249b0b)) | ||
* **speed-slider:** Use two linear functions for better speed sliding ([c37ef85](https://github.com/podlove/podlove-web-player/commit/c37ef85)) | ||
* **tests:** Add basic test coverage for utils, store and actions ([93d4906](https://github.com/podlove/podlove-web-player/commit/93d4906)) | ||
|
||
|
||
|
||
<a name="3.0.0-beta.6"></a> | ||
# [3.0.0-beta.6](https://github.com/podlove/podlove-web-player/compare/v3.0.0-alpha...v3.0.0-beta.6) (2015-11-18) | ||
|
||
|
||
|
||
<a name="2.0.17"></a> | ||
## [2.0.17](https://github.com/podlove/podlove-web-player/compare/v2.0.16...v2.0.17) (2013-10-28) | ||
|
||
|
||
|
||
<a name="2.0.16"></a> | ||
## [2.0.16](https://github.com/podlove/podlove-web-player/compare/v2.0.15...v2.0.16) (2013-10-19) | ||
|
||
|
||
|
||
<a name="2.0.15"></a> | ||
## [2.0.15](https://github.com/podlove/podlove-web-player/compare/v2.0.14...v2.0.15) (2013-09-07) | ||
|
||
|
||
|
||
<a name="2.0.14"></a> | ||
## [2.0.14](https://github.com/podlove/podlove-web-player/compare/v2.0.13...v2.0.14) (2013-09-05) | ||
|
||
|
||
|
||
<a name="2.0.13"></a> | ||
## [2.0.13](https://github.com/podlove/podlove-web-player/compare/v2.0.12...v2.0.13) (2013-07-11) | ||
|
||
|
||
|
||
<a name="2.0.12"></a> | ||
## [2.0.12](https://github.com/podlove/podlove-web-player/compare/v2.0.11...v2.0.12) (2013-07-08) | ||
|
||
|
||
|
||
<a name="2.0.11"></a> | ||
## [2.0.11](https://github.com/podlove/podlove-web-player/compare/v2.0.10...v2.0.11) (2013-06-11) | ||
|
||
|
||
|
||
<a name="2.0.10"></a> | ||
## [2.0.10](https://github.com/podlove/podlove-web-player/compare/v2.0.9...v2.0.10) (2013-05-22) | ||
|
||
|
||
|
||
<a name="2.0.9"></a> | ||
## [2.0.9](https://github.com/podlove/podlove-web-player/compare/v2.0.8...v2.0.9) (2013-05-22) | ||
|
||
|
||
|
||
<a name="2.0.8"></a> | ||
## [2.0.8](https://github.com/podlove/podlove-web-player/compare/v2.0.7...v2.0.8) (2013-05-22) | ||
|
||
|
||
|
||
<a name="2.0.7"></a> | ||
## [2.0.7](https://github.com/podlove/podlove-web-player/compare/v2.0.6...v2.0.7) (2013-04-09) | ||
|
||
|
||
|
||
<a name="2.0.6"></a> | ||
## [2.0.6](https://github.com/podlove/podlove-web-player/compare/v2.0.5...v2.0.6) (2013-04-04) | ||
|
||
|
||
|
||
<a name="2.0.5"></a> | ||
## [2.0.5](https://github.com/podlove/podlove-web-player/compare/v2.0.4...v2.0.5) (2013-03-07) | ||
|
||
|
||
|
||
<a name="2.0.4"></a> | ||
## [2.0.4](https://github.com/podlove/podlove-web-player/compare/v2.0.3...v2.0.4) (2013-03-03) | ||
|
||
|
||
|
||
<a name="2.0.3"></a> | ||
## [2.0.3](https://github.com/podlove/podlove-web-player/compare/v2.0.2...v2.0.3) (2013-02-28) | ||
|
||
|
||
|
||
<a name="2.0.2"></a> | ||
## [2.0.2](https://github.com/podlove/podlove-web-player/compare/v2.0.1...v2.0.2) (2013-02-14) | ||
|
||
|
||
|
||
<a name="2.0.1"></a> | ||
## [2.0.1](https://github.com/podlove/podlove-web-player/compare/v2.0.0...v2.0.1) (2013-02-14) | ||
|
||
|
||
|
||
<a name="2.0.0"></a> | ||
# [2.0.0](https://github.com/podlove/podlove-web-player/compare/v1.2.0...v2.0.0) (2013-02-14) | ||
|
||
|
||
|
||
<a name="1.2.0"></a> | ||
# [1.2.0](https://github.com/podlove/podlove-web-player/compare/7f4d2d7...v1.2.0) (2012-11-10) | ||
|
||
|
||
### Bug Fixes | ||
|
||
* function_exists takes a string not a constant ([7f4d2d7](https://github.com/podlove/podlove-web-player/commit/7f4d2d7)) | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,188 @@ | ||
## Submission Guidelines | ||
|
||
### Submitting an Issue | ||
Before you submit your issue search the archive, maybe your question was already answered. | ||
|
||
If your issue appears to be a bug, and hasn't been reported, open a new issue. Help us to maximize | ||
the effort we can spend fixing issues and adding new features, by not reporting duplicate issues. | ||
Providing the following information will increase the chances of your issue being dealt with | ||
quickly: | ||
|
||
* **Overview of the Issue** - if an error is being thrown a non-minified stack trace helps | ||
* **Motivation for or Use Case** - explain why this is a bug for you | ||
* **Debug State** - Attatch the debug state (settings -> click on podlove version in footer) | ||
* **Related Issues** - has a similar issue been reported before? | ||
* **Suggest a Fix** - if you can't fix the bug yourself, perhaps you can point to what might be | ||
causing the problem (line of code or commit) | ||
|
||
### Submitting a Pull Request | ||
Before you submit your pull request consider the following guidelines: | ||
|
||
* Search Pull Requests for an open or closed Pull Request | ||
that relates to your submission. You don't want to duplicate effort. | ||
* Make your changes in a new git branch: | ||
|
||
```shell | ||
git checkout -b my-fix-branch master | ||
``` | ||
|
||
* Create your patch, **including appropriate test cases**. | ||
* Run the full test suite (`yarn test`) | ||
* Commit your changes using a descriptive commit message that follows our [commit message conventions](#commit) | ||
|
||
```shell | ||
git commit -a | ||
``` | ||
Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files. | ||
|
||
* Build your changes locally to ensure all the tests pass: | ||
|
||
```shell | ||
grunt test | ||
``` | ||
|
||
* Push your branch to GitHub: | ||
|
||
```shell | ||
git push origin my-fix-branch | ||
``` | ||
|
||
In GitHub, send a pull request to `development`. | ||
If we suggest changes, then: | ||
|
||
* Make the required updates. | ||
* Re-run the test suite to ensure tests are still passing. | ||
* Commit your changes to your branch (e.g. `my-fix-branch`). | ||
* Push the changes to your GitHub repository (this will update your Pull Request). | ||
|
||
If the PR gets too outdated we may ask you to rebase and force push to update the PR: | ||
|
||
```shell | ||
git rebase master -i | ||
git push origin my-fix-branch -f | ||
``` | ||
|
||
_WARNING: Squashing or reverting commits and force-pushing thereafter may remove GitHub comments | ||
on code that were previously made by you or others in your commits. Avoid any form of rebasing | ||
unless necessary._ | ||
|
||
#### After your pull request is merged | ||
|
||
After your pull request is merged, you can safely delete your branch and pull the changes | ||
from the main (upstream) repository: | ||
|
||
* Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows: | ||
|
||
```shell | ||
git push origin --delete my-fix-branch | ||
``` | ||
|
||
* Check out the master branch: | ||
|
||
```shell | ||
git checkout master -f | ||
``` | ||
|
||
* Delete the local branch: | ||
|
||
```shell | ||
git branch -D my-fix-branch | ||
``` | ||
|
||
* Update your master with the latest upstream version: | ||
|
||
```shell | ||
git pull --ff upstream master | ||
``` | ||
|
||
## <a name="rules"></a> Coding Rules | ||
|
||
To ensure consistency throughout the source code, keep these rules in mind as you are working: | ||
|
||
* All features or bug fixes **must be tested** by one or more [specs][unit-testing]. | ||
* All public API methods **must be documented** with ngdoc, an extended version of jsdoc (we added | ||
support for markdown and templating via @ngdoc tag). To see how we document our APIs, please check | ||
out the existing source code and see [this wiki page][ngDocs]. | ||
* With the exceptions listed below, we follow the rules contained in | ||
[Google's JavaScript Style Guide][js-style-guide]: | ||
* **Do not use namespaces**: Instead, wrap the entire AngularJS code base in an anonymous closure and | ||
export our API explicitly rather than implicitly. | ||
* Wrap all code at **100 characters**. | ||
* Instead of complex inheritance hierarchies, we **prefer simple objects**. We use prototypal | ||
inheritance only when absolutely necessary. | ||
* We **love functions and closures** and, whenever possible, prefer them over objects. | ||
* To write concise code that can be better minified, we **use aliases internally** that map to the | ||
external API. See our existing code to see what we mean. | ||
* We **don't go crazy with type annotations** for private internal APIs unless it's an internal API | ||
that is used throughout AngularJS. The best guidance is to do what makes the most sense. | ||
## <a name="commit"></a> Git Commit Guidelines | ||
We have very precise rules over how our git commit messages can be formatted. This leads to **more | ||
readable messages** that are easy to follow when looking through the **project history**. But also, | ||
we use the git commit messages to **generate the AngularJS change log**. | ||
The commit message formatting can be added using a typical git workflow or through the use of a CLI | ||
wizard ([Commitizen](https://github.com/commitizen/cz-cli)). To use the wizard, run `yarn commit` | ||
in your terminal after staging your changes in git. | ||
### Commit Message Format | ||
Each commit message consists of a **header**, a **body** and a **footer**. The header has a special | ||
format that includes a **type**, a **scope** and a **subject**: | ||
``` | ||
<type>(<scope>): <subject> | ||
<BLANK LINE> | ||
<body> | ||
<BLANK LINE> | ||
<footer> | ||
``` | ||
The **header** is mandatory and the **scope** of the header is optional. | ||
Any line of the commit message cannot be longer 100 characters! This allows the message to be easier | ||
to read on GitHub as well as in various git tools. | ||
### Revert | ||
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit. | ||
In the body it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted. | ||
### Type | ||
Must be one of the following: | ||
* **feat**: A new feature | ||
* **fix**: A bug fix | ||
* **docs**: Documentation only changes | ||
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing | ||
semi-colons, etc) | ||
* **refactor**: A code change that neither fixes a bug nor adds a feature | ||
* **perf**: A code change that improves performance | ||
* **test**: Adding missing or correcting existing tests | ||
* **chore**: Changes to the build process or auxiliary tools and libraries such as documentation | ||
generation | ||
### Scope | ||
The scope could be anything specifying place of the commit change. For example `$location`, | ||
`$browser`, `$compile`, `$rootScope`, `ngHref`, `ngClick`, `ngView`, etc... | ||
You can use `*` when the change affects more than a single scope. | ||
### Subject | ||
The subject contains succinct description of the change: | ||
* use the imperative, present tense: "change" not "changed" nor "changes" | ||
* don't capitalize first letter | ||
* no dot (.) at the end | ||
|
||
### Body | ||
Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes". | ||
The body should include the motivation for the change and contrast this with previous behavior. | ||
|
||
### Footer | ||
The footer should contain any information about **Breaking Changes** and is also the place to | ||
[reference GitHub issues that this commit closes][closing-issues]. | ||
|
||
**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. | ||
The rest of the commit message is then used for this. | ||
|
||
A detailed explanation can be found in this [document][commit-message-format]. |
Oops, something went wrong.