Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set target="_top" on links #50

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: set target="_top" on links #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions client/src/components/button/Button.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
class="inline-flex items-center focus:outline-none focus:ring-2 border border-transparent shadow-sm whitespace-nowrap disabled:opacity-75"
:disabled="disabled"
:class="[variantClass, sizeClass]"
:target="target"
>
<slot />
</component>
Expand All @@ -30,6 +31,7 @@ interface Props {
size?: ButtonSize;
disabled?: boolean;
type?: 'button' | 'a';
target?: string;
}

const props = defineProps<Props>();
Expand Down Expand Up @@ -67,6 +69,14 @@ const sizeClass = computed(() => {
return `px-6 py-3 text-base font-medium rounded-md`;
}
});

const target = computed(() => {
if (type.value != 'a') {
return null;
}

return props.target || null;
});
</script>

<style></style>
2 changes: 1 addition & 1 deletion client/src/i18n/de.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export default {
headline: 'Ziehe Deinen Podcast zu Podlove um',
description:
'In den folgenden Schritten kannst Deinen bestehenden Podcast zu Podlove umziehen. Gib einfach die RSS-Feed-URL deines aktuellen Podcasts unten ein. Die RSS-Feed-URL ist ein spezieller Link, der den Inhalt deines Podcasts zusammenfasst und es Plattformen ermöglicht, diesen Inhalt zu lesen und anzuzeigen.',
help: 'Die RSS-Feed-URL findest Du normalerweise in den Einstellungen oder im Dashboard Deiner aktuellen Hosting-Plattform. Hinweise, wie Du die RSS-Feed-URL bei einzelnen Hosting-Plattformen finden kannst, haben wir und die Community in diesem <a class="support-link" href="https://sendegate.de/t/podcast-feed-bei-hosting-plattformen-finden-wiki/17116">Post</a> im Sendegate zusammengefasst.',
help: 'Die RSS-Feed-URL findest Du normalerweise in den Einstellungen oder im Dashboard Deiner aktuellen Hosting-Plattform. Hinweise, wie Du die RSS-Feed-URL bei einzelnen Hosting-Plattformen finden kannst, haben wir und die Community in diesem <a class="support-link" href="https://sendegate.de/t/podcast-feed-bei-hosting-plattformen-finden-wiki/17116" target="_top">Post</a> im Sendegate zusammengefasst.',
'feed-url': 'Podcast feed URL',
'feed-url-placeholder': 'Podcast-Feed-URL eingeben',
'success-head': 'Super!',
Expand Down
2 changes: 1 addition & 1 deletion client/src/i18n/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export default {
headline: 'Move your Podcast to Podlove',
description:
"Let's get started on bringing your existing podcast over to Podlove. Simply enter the RSS feed URL of your current podcast below.",
help: 'You can usually find the RSS feed URL in the settings or dashboard of your current hosting platform. For more detailed instructions on finding your RSS feed URL with popular hosting platforms, check out this <a class="support-link" href="https://sendegate.de/t/podcast-feed-bei-hosting-plattformen-finden-wiki/17116">post</a> in the Sendegate.',
help: 'You can usually find the RSS feed URL in the settings or dashboard of your current hosting platform. For more detailed instructions on finding your RSS feed URL with popular hosting platforms, check out this <a class="support-link" href="https://sendegate.de/t/podcast-feed-bei-hosting-plattformen-finden-wiki/17116" target="_top">post</a> in the Sendegate.',
'feed-url': 'Podcast feed URL',
'feed-url-placeholder': 'Enter the feed url',
'success-head': 'Success!',
Expand Down
2 changes: 1 addition & 1 deletion client/src/pages/onboarding/steps/import/NextSteps.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
/>
</div>
<div class="text-center">
<PodloveButton :href="episodesListLink" type="a" variant="primary">{{
<PodloveButton :href="episodesListLink" type="a" target="_top" variant="primary">{{
$t('onboarding.steps.import-next-steps.button')
}}</PodloveButton>
</div>
Expand Down
Loading