Feature/create show with hosts #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwingert ONE wish, since there is a commit where the tests have failed I would like to merge this PR as squash. If you dont have any objections ... |
|
@electronicbites Of course, no objections, squash it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reworked
Showform with an addeddescriptionfield and a list ofhosts.The form contains a search field for searching through existing users by email.
Found users can be added to the list of hosts.
The form is still placed inside the Admin LiveView.
Extracting it into it's own details page and allowing editing as well would be done in another PR.
Some notes regarding creating the show with associated hosts:
It's done in steps inside a transaction.