feat: adding utility methods for interacting with minikube executable #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
force-pushed
the
feature/adding-utility-methods
branch
from
ef2b044 to
d75df34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding utility methods required by #156 and make smaller PR.
Notable changes
installBinaryToSystemto return the path where it installed the binarygetBinarySystemPathto have a single method deciding where the binary should be installed system-widewhereBinaryto detect the binary if installed system wide (copied from podman-desktop#extensions/kind/src/util.ts#L97deleteFilewhich try to delete a file and if failed try with admin privilege (copy from podman-desktop#extensions/kind/src/extension.ts#L489))SpawnResultandRunOptions(could be a separate PR if this is too much)Tests