Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update podman api and replace local runCliCommand with process.exec #44

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: update podman api and replace local runCliCommand with process.exec #44

merged 1 commit into from
May 22, 2024

Conversation

lstocchi
Copy link
Contributor

This PR just updates the podman desktop api and replace the runCliCommand with the process.exec function from the api.

@lstocchi lstocchi requested review from benoitf and a team as code owners May 22, 2024 12:46
jeffmaury
jeffmaury approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit 90c3701 into podman-desktop:main May 22, 2024
4 checks passed
@lstocchi lstocchi deleted the updateAPI branch May 22, 2024 14:52
@lstocchi lstocchi mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

@benoitf benoitf benoitf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lstocchi @benoitf @jeffmaury