Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: light mode for welcome page #8401

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

deboer-tim
Copy link
Contributor

What does this PR do?

Replaces hard-coded colors with color variables, and converts several elements from custom styling to standard components like Checkbox, Link, and IconImage.

Screenshot / video of UI

Light:

Screenshot 2024-08-08 at 11 16 56 AM

Dark:

Screenshot 2024-08-08 at 11 21 11 AM

What issues does this PR fix or reference?

Fixes #8397.

How to test this PR?

Remove welcome property from settings.json and try in light and dark mode.

Replaces hard-coded colors with color variables, and converts several elements
from custom styling to standard components like Checkbox, Link, and IconImage.

Fixes podman-desktop#8397.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim requested review from benoitf and a team as code owners August 8, 2024 15:34
@deboer-tim deboer-tim requested review from axel7083, lstocchi and SoniaSandler and removed request for a team August 8, 2024 15:34
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deboer-tim deboer-tim merged commit f8013ca into podman-desktop:main Aug 8, 2024
7 checks passed
@deboer-tim deboer-tim deleted the light-welcome branch August 8, 2024 20:02
@podman-desktop-bot podman-desktop-bot added this to the 1.13.0 milestone Aug 8, 2024
@deboer-tim deboer-tim mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome page with telematics checkbox is dark mode only
4 participants